Skip to content

chore: prepare the template for public access #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
petrkonecny2 merged 18 commits into from
Apr 25, 2025
Merged

chore: prepare the template for public access #43

petrkonecny2 merged 18 commits into from
Apr 25, 2025

Conversation

@petrkonecny2
Copy link
Contributor

@petrkonecny2 petrkonecny2 commented Apr 22, 2025 •
edited
Loading

Description

This PR prepares the Expo template for public release so it is usable outside of STRV. This includes number of changes:

Removed/updated some libraries and config changes

  • Removed Zustand and all references to it as we don't want to be that opinionated
  • Switched Runtime version policy to fingerprinting from sdkversion to support OTA updates on all levels reliably.
  • Updated RN version to be compatible with Xcode 16.3

Slightly updated the folder structure based on our recent projects

  • Storage moved to services/storage to encourage that pattern
  • Moved basic components like Buttons to features/ui as we have done recently
  • Moved everything to do with versioning to features/versionCheck

Some changes to the version check utilities based on our recent project implementations

  • Added more granularity, you can now set both recommended or forced version for ios/android separately
  • replaced all of the custom version parsing with Semver package functions

Some other minor changes

  • Removed prefixing interfaces with I and changed interfaces to types
  • Created common styles for styles like flex 1 and other commonly used ones

Last but definitely not least docs changes

  • split into sections,
  • changed intro
  • removed duplications
  • updated STRV recommended libs

Related Tickets/Issues

@matejpolak
Copy link
Contributor

matejpolak commented Apr 25, 2025 •
edited
Loading

Should we move src/styles/common.ts into the newly created src/features/ui/theme and get rid of src/styles completely?

matejpolak
matejpolak reviewed Apr 25, 2025
View reviewed changes
@petrkonecny2
Copy link
Contributor Author

petrkonecny2 commented Apr 25, 2025

Should we move src/styles/common.ts into the newly created src/features/ui/theme and get rid of src/styles completely?

Good question, I am not sure, it is really not a theme but just some utility styles. So we had it on the project in this folder. And since you are importing it all over it maybe makes sense to have it on the root. But it can be either way. I would probably let that up to the user of the template where they want to put it.

@matejpolak
Copy link
Contributor

matejpolak commented Apr 25, 2025

Should we move src/styles/common.ts into the newly created src/features/ui/theme and get rid of src/styles completely?

Good question, I am not sure, it is really not a theme but just some utility styles. So we had it on the project in this folder. And since you are importing it all over it maybe makes sense to have it on the root. But it can be either way. I would probably let that up to the user of the template where they want to put it.

I see. I would still move it to features/ui as it's 100% related to UI IMHO. But ok, we can keep it as is, can you please add a little JSDoc comment to the file to explicitly explain this?

@petrkonecny2
Copy link
Contributor Author

petrkonecny2 commented Apr 25, 2025

Should we move src/styles/common.ts into the newly created src/features/ui/theme and get rid of src/styles completely?

Good question, I am not sure, it is really not a theme but just some utility styles. So we had it on the project in this folder. And since you are importing it all over it maybe makes sense to have it on the root. But it can be either way. I would probably let that up to the user of the template where they want to put it.

I see. I would still move it to features/ui as it's 100% related to UI IMHO. But ok, we can keep it as is, can you please add a little JSDoc comment to the file to explicitly explain this?

I think you are right and it would be good to get rid of the styles folder. Moved it under features/ui/styles (not features/ui/theme/styles).

@petrkonecny2 petrkonecny2 merged commit 03df698 into main Apr 25, 2025
1 check passed
@petrkonecny2 petrkonecny2 deleted the chore/template-update branch April 25, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matejpolak matejpolak matejpolak approved these changes

@pchalupa pchalupa Awaiting requested review from pchalupa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@petrkonecny2 @matejpolak